Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicate icon closing tag #6248

Merged

Conversation

walidmujahid
Copy link
Contributor

Description

Removes a duplicate closing tag.

Refers/Fixes
Testing

@codecov
Copy link

codecov bot commented Mar 17, 2020

Codecov Report

Merging #6248 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6248      +/-   ##
==========================================
+ Coverage   28.24%   28.29%   +0.04%     
==========================================
  Files         278      278              
  Lines       25403    25341      -62     
  Branches     3718     3709       -9     
==========================================
- Hits         7175     7169       -6     
+ Misses      17947    17891      -56     
  Partials      281      281
Impacted Files Coverage Δ
app/dashboard/views.py 11.31% <0%> (-0.02%) ⬇️
app/app/urls.py 91.07% <0%> (ø) ⬆️
...perftools/management/commands/create_page_cache.py 0% <0%> (ø) ⬆️
app/avatar/views_3d.py 9.59% <0%> (ø) ⬆️
app/app/context.py 75.64% <0%> (ø) ⬆️
app/grants/views.py 16.46% <0%> (+0.03%) ⬆️
app/app/utils.py 23.75% <0%> (+0.07%) ⬆️
app/townsquare/views.py 10.83% <0%> (+0.09%) ⬆️
app/dashboard/models.py 50.61% <0%> (+0.17%) ⬆️
app/townsquare/models.py 56.65% <0%> (+0.19%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33ab7b5...e1904e8. Read the comment docs.

@walidmujahid walidmujahid force-pushed the remove-duplicate-icon-closing-tag branch 2 times, most recently from 6fe2f03 to e422eab Compare March 18, 2020 02:25
@walidmujahid walidmujahid force-pushed the remove-duplicate-icon-closing-tag branch from e422eab to f9dd5a8 Compare March 18, 2020 02:35
Copy link
Contributor

@octavioamu octavioamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good find, thanks man!!

@thelostone-mc thelostone-mc merged commit a55de14 into gitcoinco:master Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants